For me it feels more work. If I add a signoff, I must have tested the patch more extensively. But if I do not need to add signoff and I can rely on a solid signoff already, the QA process will be faster. Note that I do not oppose this step, I am just warning that it takes more time. I do not favor only adding a signoff line without more testing. This would create a "false feeling of security".
Marcel -----Oorspronkelijk bericht----- Van: Chris Cormack [mailto:[email protected]] Verzonden: maandag 26 november 2012 9:28 Aan: Marcel de Rooy CC: Jared Camins-Esakov; [email protected] Onderwerp: Re: [Koha-devel] [QA] QAing and signing off On 26 November 2012 21:25, Marcel de Rooy <[email protected]> wrote: > Testing is more than checking if it applies :) Of course it is, but you can hardly QA something if you haven't even applied it. My point is, applying a patch then doing your QA then signing that patch off ... the only change is adding the sign off. All Jared is asking is, that if you mark a patch passed-qa you add a sign off to it. Chris _______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
