----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/226/ -----------------------------------------------------------
Review request for Kopete and Roman Jarosz. Summary ------- This patch adds wrappers around Kopete::MetaContact (MetaContactWrapper) and Kopete::Group (GroupWrapper). The reason for this is to be able to tell in which group MetaContact is because MetaContact can be in more groups and when we want to create parent QModelIndex we only have pointer to metaContact so the MetaContactWrapper object is created every time MetaContact is added to some group. I'm posting it here because it's not the nicest solution but I don't see any better right now. So do you agree with this change? PS. group wrapper isn't needed but IMHO it's cleaner this way because otherwise we would have to do some casting magic. Diffs ----- /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistmodel.h 933212 /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistmodel.cpp 933293 /branches/work/kopete/dev-4.2/kopete/contactlist/kopetecontactlistview.h 933323 /branches/work/kopete/dev-4.2/kopete/contactlist/kopetecontactlistview.cpp 933323 /branches/work/kopete/dev-4.2/libkopete/kopetecontactlist.h 932952 /branches/work/kopete/dev-4.2/libkopete/kopetecontactlist.cpp 932952 Diff: http://reviewboard.kde.org/r/226/diff Testing ------- Thanks, Roman _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
