Lamarque Souza wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/971/ > ----------------------------------------------------------- > > (Updated 2009-07-10 07:20:32.547875) > > > Review request for Kopete. > > > Changes > ------- > > Instructions for quick and dirty installation, which can help people test > this patch. > > > Summary (updated) > ------- > > The patch implements mail notification and open inbox feature for wlm plugin. > It also adds four new strings for translation. I am using it with Kopete > 4.2.4 with no problems so far. The open inbox feature depends on this patch > applied against libmsn: > http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff > > This is a quick and dirty way to test this patch: > > wget > http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff > wget http://gentoo.oregonstate.edu/distfiles/libmsn-4.0-beta5.tar.bz2 > tar jxf libmsn-4.0-beta5.tar.bz2 > cd libmsn-4.0-beta5 > patch -p3 < ../libmsn-4.0_beta5-open_inbox.diff > mkdir ../libmsn-4.0-beta5_build > cd ../libmsn-4.0-beta5_build > cmake ../libmsn-4.0-beta5 > make; make install > > # Do backup of your kopete_wlm.so file first, usually it is located at > $KDEDIR/lib/kde4/ > # Download kopete-wlm_mail_notification_and_open_inbox.diff using the > "Download Diff" button at http://reviewboard.kde.org/r/971/ > wget ftp://ftp.kde.org/pub/kde/stable/4.2.4/src/kdenetwork-4.2.4.tar.bz2 > tar jxf kdenetwork-4.2.4.tar.bz2 > cd kdenetwork-4.2.4/kopete/ > patch -p0 < kopete-wlm_mail_notification_and_open_inbox.diff > mkdir ../../kdenetwork-4.2.4_build > cd ../../kdenetwork-4.2.4_build > cmake ../kdenetwork-4.2.4 > cd ../kdenetwork-4.2.4/kopete > make > cp ../lib/kopete_wlm.so /usr/kde/4.2/lib64/kde4/kopete_wlm.so # or the > location of your kopete_wlm.so plugin. > > Run Kopete :-) OBS: this installation method is not well tested and may not > work for everybody. > > > This addresses bug 163225. > https://bugs.kde.org/show_bug.cgi?id=163225 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.h 994057 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 994059 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.h 994057 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.cpp 994057 > > Diff: http://reviewboard.kde.org/r/971/diff > > > Testing > ------- > > > Screenshots > ----------- > > Notification with ignore button > http://reviewboard.kde.org/r/971/s/138/ > > > Thanks, > > Lamarque > > _______________________________________________ > kopete-devel mailing list > kopete-devel@kde.org > https://mail.kde.org/mailman/listinfo/kopete-devel > Hi,
Thanks for the patches. I've changed them a bit and created a new struct to fill with hotmail information in libmsn. I personally don't like to include html code into the c++ source, but I can't find a better way to do that than creating a template file and replace the strings on the fly. Another problem is that we set autoRemove to false, and other people accessing this temporary file would access the inbox of this user. This is a serious security issue. Please take a look at the patches and test them. (the problem of the libmsn patch is that it breaks the api compatibility, but there is no other way to implement this feature without breaking the api.) this patch for libmsn -> http://pastebin.com/m45926ab8 and this one for wlm -> http://pastebin.com/m7de5dae9 Regards. _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
