----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/#review1530 -----------------------------------------------------------
This patch is a little rough to go in as-is. The security vulnerability is not acceptable, especially not when KParts::BrowserRun can be used to provide the same behavior. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment953> k_funcinfo is no longer needed with KDE 4 and should be removed. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment954> fix the whitespace error here (highlighted in red) /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment955> whitespace here too /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment956> fix whitespace /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment957> Don't wrap new code in #if 0. Just take it out. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment958> no k_funcinfo here /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment959> no #if 0'ed code here either. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment962> I'm not happy with this. Use KParts::BrowserRun instead please. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment960> no #if 0 code here either. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment961> remove this part. it shouldn't be part of the patch. add it as another commit later. - Matt On 2009-07-10 09:02:21, Lamarque Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/971/ > ----------------------------------------------------------- > > (Updated 2009-07-10 09:02:21) > > > Review request for Kopete. > > > Summary > ------- > > The patch implements mail notification and open inbox feature for wlm plugin. > It also adds four new strings for translation. I am using it with Kopete > 4.2.4 with no problems so far. The open inbox feature depends on this patch > applied against libmsn: > http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff > > This is a quick and dirty way to test this patch: > > wget > http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff > wget http://gentoo.oregonstate.edu/distfiles/libmsn-4.0-beta5.tar.bz2 > tar jxf libmsn-4.0-beta5.tar.bz2 > cd libmsn-4.0-beta5 > patch -p3 < ../libmsn-4.0_beta5-open_inbox.diff > mkdir ../libmsn-4.0-beta5_build > cd ../libmsn-4.0-beta5_build > cmake ../libmsn-4.0-beta5 > make; make install > > # Do backup of your kopete_wlm.so file first, usually it is located at > $KDEDIR/lib/kde4/ > # Download kopete-wlm_mail_notification_and_open_inbox.diff using the > "Download Diff" button at http://reviewboard.kde.org/r/971/ > wget ftp://ftp.kde.org/pub/kde/stable/4.2.4/src/kdenetwork-4.2.4.tar.bz2 > tar jxf kdenetwork-4.2.4.tar.bz2 > cd kdenetwork-4.2.4/kopete/ > patch -p0 < kopete-wlm_mail_notification_and_open_inbox.diff > mkdir ../../kdenetwork-4.2.4_build > cd ../../kdenetwork-4.2.4_build > cmake ../kdenetwork-4.2.4 > cd ../kdenetwork-4.2.4/kopete > make > cp ../lib/kopete_wlm.so /usr/kde/4.2/lib64/kde4/kopete_wlm.so # or the > location of your kopete_wlm.so plugin. > > Run Kopete :-) OBS: this installation method is not well tested and may not > work for everybody. > > > This addresses bug 163225. > https://bugs.kde.org/show_bug.cgi?id=163225 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/wlm/CMakeLists.txt 994428 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.h 994057 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 994059 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.h 994057 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.cpp 994057 > > Diff: http://reviewboard.kde.org/r/971/diff > > > Testing > ------- > > > Screenshots > ----------- > > Notification with ignore button > http://reviewboard.kde.org/r/971/s/138/ > > > Thanks, > > Lamarque > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
