----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2179/ -----------------------------------------------------------
Review request for Kopete. Summary ------- This patch allows a new configuration option to be set which will show all offline users grouped into a folder called "Offline Users". When a contact comes online, the metacontact is removed from the offline group, and added to the normal group folder. Likewise when the contact goes offline, the contact is added to the offline users folder. Rules: If "Show Offline" is set, then the offline folder group is removed from view. If a search is in progress, the offline folder is removed from view. Using the proxyfilter lessThan, the Offline folder is always pushed to the bottom of the list. Protection: Removed right click access to the folder so no renaming etc can be done (wise?). Removed ability for a user to move a contact to the offline folder. Side Effects: The offline users folder is always visible even when not connected to a network. Implementation: The offline folder is a "special" group like temporary or toplevel. This allows it to hide away from the group menus while still being filterable. Future: Assuming anyone is interested in this feature, there are a couple of cosmetic changes that might be made. One is... The offline folder will never have an online contact, so instead of showing "Offline Users (0/1000)" it could be abbreviated to "Offline Users (1000)" Questions: If we simply call the folder "Offline" would we get better i18n? Is there a better way to do this? built against 0.80.2 Diffs ----- /branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_contactlist.ui 1046954 /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/kopetecontactliststorage.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontactlist.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.h 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.cpp 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1046954 Diff: http://reviewboard.kde.org/r/2179/diff Testing ------- Tested against 0.80.2 in /branches/KDE/4.3/kdenetwork/ Screenshots ----------- Offline Users http://reviewboard.kde.org/r/2179/s/262/ Thanks, Barry _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
