Em Saturday 25 February 2012, Pali Rohár escreveu: > Here is updated patch which apply on kopete from trunk.
The patch seems good to go. Since it adds new strings it should be applied only to master (trunk) and will availlable only in 4.9.0. > On Sunday 04 July 2010 02:14:47 Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/2179/#review6362 > > ----------------------------------------------------------- > > > > > > Well, nobody has given a NACK yet, so I presume this is a tacit ACK :) > > > > Does this patch still apply fine to trunk? It'd be good to apply it now > > that trunk is unfrozen for SC 4.6. > > > > - Raphael > > > > On 2009-11-18 04:12:17, Barry Carter wrote: > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > http://reviewboard.kde.org/r/2179/ > > > ----------------------------------------------------------- > > > > > > (Updated 2009-11-18 04:12:17) > > > > > > > > > Review request for Kopete. > > > > > > > > > Summary > > > ------- > > > > > > This patch allows a new configuration option to be set which will show > > > all offline users grouped into a folder called "Offline Users". > > > > > > When a contact comes online, the metacontact is removed from the > > > offline group, and added to the normal group folder. Likewise when the > > > contact goes offline, the contact is added to the offline users > > > folder. > > > > > > Rules: > > > If "Show Offline" is set, then the offline folder group is removed from > > > view. If a search is in progress, the offline folder is removed from > > > view. Using the proxyfilter lessThan, the Offline folder is always > > > pushed to the bottom of the list. > > > > > > Protection: > > > Removed right click access to the folder so no renaming etc can be done > > > (wise?). Removed ability for a user to move a contact to the offline > > > folder. > > > > > > Side Effects: > > > The offline users folder is always visible even when not connected to a > > > network. > > > > > > Implementation: > > > The offline folder is a "special" group like temporary or toplevel. > > > This allows it to hide away from the group menus while still being > > > filterable. > > > > > > Future: > > > Assuming anyone is interested in this feature, there are a couple of > > > cosmetic changes that might be made. One is... The offline folder will > > > never have an online contact, so instead of showing "Offline Users > > > (0/1000)" it could be abbreviated to "Offline Users (1000)" > > > > > > Questions: > > > If we simply call the folder "Offline" would we get better i18n? > > > Is there a better way to do this? > > > > > > built against 0.80.2 > > > > > > > > > Diffs > > > ----- > > > > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/config/appearance/appearan > > > cec onfig_contactlist.ui 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlistpro > > > xy model.cpp 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/contactlisttre > > > em odel.cpp 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopetecontactl > > > is tview.cpp 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/kopete/contactlist/kopeteitemdele > > > ga te.cpp 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/kopeteconta > > > ct liststorage.cpp 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/libkopete/contactlist/xmlcontacts > > > to rage.cpp 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopeteappearancesetting > > > s. kcfg 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetecontactlist.cpp > > > 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.h > > > 1046954 /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetegroup.cpp > > > 1046954 > > > /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetemetacontact.cpp > > > 1046954> > > > > > > Diff: http://reviewboard.kde.org/r/2179/diff > > > > > > > > > Testing > > > ------- > > > > > > Tested against 0.80.2 in /branches/KDE/4.3/kdenetwork/ > > > > > > > > > Screenshots > > > ----------- > > > > > > Offline Users > > > > > > http://reviewboard.kde.org/r/2179/s/262/ > > > > > > Show offline contacts in a separate folder > > > > > > http://reviewboard.kde.org/r/2179/s/265/ > > > > > > Offline Users cleanup > > > > > > http://reviewboard.kde.org/r/2179/s/266/ > > > > > > Thanks, > > > > > > Barry -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel