Can I get this reviewed/commented on? Weekend is approaching and I might have a bit of time to change things if there will be comments on it or on the coding style :-) Don't know about you but I was bugged by the yahoo transfer not working most of the time for a long time...
Regards. On Sun, Jan 16, 2011 at 12:33 PM, Cristi P <cristi.pos...@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6339/ > Review request for Kopete. > By Cristi P. > Description > > Receive part: > a) protocol (as reading from various places) suggests that first a HEAD and > then GET should be done. Current code was asking them in parallel. > b) fixed the way sending the header was done. > > Sending: > a) changed to an async method of doing the send > b) send buffer size is dynamic to try to send as much as possible > c) ... various - made it work. > > Maybe fixes also #194833 although I'm not very sure what is that one about. > > Testing > > sending from kopete to pidgin and Yahoo messenger, and the other way around. > Sending was always failing for me. > (and posted a patch to pidgin/libpurple as well :-) ) > > *Bugs: * <https://bugs.kde.org/show_bug.cgi?id=>, > 242557<https://bugs.kde.org/show_bug.cgi?id=242557> > Diffs > > - trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp > (1214563) > - trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.h > (1214563) > - trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.h > (1214563) > - trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp > (1214563) > > View Diff <http://svn.reviewboard.kde.org/r/6339/diff/> >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
