> On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp, > > line 143 > > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44270#file44270line143> > > > > Can you add a TODO: here to make it easier to spot this comment?
maybe a SEEME: Because I don't think Yahoo will ever change their protocol in that part, to make it really http compliant. it will break maybe too many programs outthere. > On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp, > > line 148 > > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44270#file44270line148> > > > > If the check is disabled, I'd just comment it out or put it inside an > > #if 0 block. #if 0 block it will be. > On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp, > > line 294 > > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44270#file44270line294> > > > > Coding style: set to 0, not NULL (also applies to m_transferJob). mkay. done, using 0L (that's what I seem to find, and not plain 0). Also, just an observation - this thing is also not enforced on all the code - run a fgrep NULL ... > On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp, > > line 250 > > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44272#file44272line250> > > > > const int; can you also change the name to something more meaningful? will do > On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.h, > > line 71 > > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44269#file44269line71> > > > > Coding style: foo( bar ) instead of foo(bar) sorry, but no. a) that's a really weird indentation to me. b) there's already mixed calls - like the one you suggested or like the one I wrote it. you can check. So, again, no, I don't have time doing this kind of change - I think the style I wrote it in is acceptable. Feel free to change it if you insist on this one. > On Jan. 22, 2011, 6:31 p.m., Raphael Kubo da Costa wrote: > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp, > > line 37 > > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44272#file44272line37> > > > > Can you change these #define's to const int's? will do (*static* const int) I'll have a new patch these days, after testing. - Cristi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6339/#review9677 ----------------------------------------------------------- On Jan. 16, 2011, 10:33 a.m., Cristi P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6339/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 10:33 a.m.) > > > Review request for Kopete. > > > Summary > ------- > > Receive part: > a) protocol (as reading from various places) suggests that first a HEAD and > then GET should be done. Current code was asking them in parallel. > b) fixed the way sending the header was done. > > Sending: > a) changed to an async method of doing the send > b) send buffer size is dynamic to try to send as much as possible > c) ... various - made it work. > > Maybe fixes also #194833 although I'm not very sure what is that one about. > > > This addresses bugs and 242557. > https://bugs.kde.org/show_bug.cgi?id= > https://bugs.kde.org/show_bug.cgi?id=242557 > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp > 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.h > 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.h > 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp > 1214563 > > Diff: http://svn.reviewboard.kde.org/r/6339/diff > > > Testing > ------- > > sending from kopete to pidgin and Yahoo messenger, and the other way around. > Sending was always failing for me. > (and posted a patch to pidgin/libpurple as well :-) ) > > > Thanks, > > Cristi > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
