> On Feb. 18, 2011, 10:20 a.m., Pali Rohár wrote: > > I tested this patch. Works fine, only one suggestion: > > > > When I disconnect from Internet, Kopete set all accounts to offline status. > > But does not set global status to offline too. So in > > AccountManager::suspend() could be code for saving actual global status and > > setting to offline. And in resume() could be restoring saved global status.
Can this be done with Kopete::StatusManager::self()->setGlobalStatus()? I don't understand why this method writes something to the config. - alter_schwede ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6511/#review9885 ----------------------------------------------------------- On Feb. 17, 2011, 8:02 p.m., alter_schwede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6511/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2011, 8:02 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > I already posted this patch here: > https://bugs.kde.org/show_bug.cgi?id=149544 > > This patch logs off each account when PC is suspended and restores the online > state of each account on resume. > This patch also addresses another problem of kopete: When the user was > setting kopete to "Offline" and the network connection was lost and recovered > kopete would reset all accounts to "Online". > > > This addresses bug 149544. > https://bugs.kde.org/show_bug.cgi?id=149544 > > > Diffs > ----- > > /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h 1219275 > /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp 1219275 > /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h > 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp > 1219275 > > Diff: http://svn.reviewboard.kde.org/r/6511/diff > > > Testing > ------- > > > Thanks, > > alter_schwede > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
