----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6511/#review9903 -----------------------------------------------------------
/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp <http://svn.reviewboard.kde.org/r/6511/#comment11067> >> Kopete::StatusMessage statusMessage( i18n( "Offline" ), ""); I think this is bad idea. User can configure own status title and message in kopete configuration dialog. Some protocols (skype) support status message (on server) when account is disconnected. So we may respect user settings. This code (was in original file) try to find if user has own status title/message for offline status: QList <Kopete::Status::StatusItem *> statusList = Kopete::StatusManager::self()->getRootGroup()->childList(); QString message, title; bool found = false; //find first Status for OnlineStatus for ( QList <Kopete::Status::StatusItem *>::ConstIterator it = statusList.constBegin(); it != statusList.constEnd(); ++it ) { if ( ! (*it)->isGroup() && (*it)->category() == Kopete::OnlineStatusManager::Offline ) { title = (*it)->title(); message = (static_cast <Kopete::Status::Status*> (*it))->message(); //if it is not group, it status found = true; break; } } - Pali On Feb. 23, 2011, 1:55 a.m., alter_schwede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6511/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2011, 1:55 a.m.) > > > Review request for Kopete. > > > Summary > ------- > > I already posted this patch here: > https://bugs.kde.org/show_bug.cgi?id=149544 > > This patch logs off each account when PC is suspended and restores the online > state of each account on resume. > This patch also addresses another problem of kopete: When the user was > setting kopete to "Offline" and the network connection was lost and recovered > kopete would reset all accounts to "Online". > > > This addresses bug 149544. > https://bugs.kde.org/show_bug.cgi?id=149544 > > > Diffs > ----- > > /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h 1219275 > /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp 1219275 > /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h > 1219275 > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp > 1219275 > > Diff: http://svn.reviewboard.kde.org/r/6511/diff > > > Testing > ------- > > > Thanks, > > alter_schwede > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
