On Wednesday 15 May 2013 21:30:12 Valentin Rusu wrote: > On Wednesday 15 May 2013 09:22:12 Pali Rohár wrote: > > > A quick check let me find-up that LibOTR 4 installs the > > > same file names as previous 3 version. But the 4th > > > version introduces large changes in the API and kopete > > > simply won't compile on my ArchLinux. It's even worst > > > than that! The data structures members have been > > > re-ordered (have a look to otrlchatinterface.cpp line 315 > > > - the structure > > > OtrlMessageAppOps has undergone large changes). So > > > FindLibOTR should fail if versions >=4 are found. Is that > > > possible? > > > > I very very quickly read that cmake script and wrote this > > patch. Can you test if if now fail with version 4? It > > working fine with 3.2.1. > > OK, not it compiles by disabling LibOTR. The cmake summary > configuration may also be adjusted because it may be > misleading with it's 'libotr (3.2.0 or *higher*)' : > > -------------------------------------------------------------- > --------------- -- The following OPTIONAL packages could NOT > be located on your system. -- Consider installing them to > enable more features from this software. > ------------------------------------------------------------- > ---------------- * libotr (3.2.0 or higher) > <http://www.cypherpunks.ca/otr> A library to encrypt messages > with Off-the-Record encryption > > Do want me to revert the CMakeLists.txt or you'll take care > about that when comitting your patch?
Go ahead, revert change in CMakeLists.txt, add version info to summary and commit patch. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
