>If I understood correctly, the /usr/bin (and /bin) builtins are
>compatible with the Solaris version.  If that's true, then I think this
>is fine from an interface point of view.
>
>The fact that we need to crawl through code is a bad sign, though.
>Duplicate code introduces the possibility of making a change in one
>place and not the other, leading to bugs.  It would be better to
>refactor, so that ksh93 and the Solaris binary can share common code.

Seconded.  I feel very uncomfortable about the whole "plain
commands as builtins" issue.  Unless they are refactored into
common apps, I'd be in favour of not enabling any of the builtins
except those which commonly are (test, echo, [ ).  Correctness trumps
performance.

Casper

Reply via email to