Below are the locations of the new webrev with Roland's latest changes, based
on Peter Memishian's review of the Makefile changes from round 1 of the final
code review (June 29th version, announced on July 2nd).
We would appreciate code review comments by end of this week if possible...
we'd like to wrap up the code by the beginning of next week.
In particular, we're looking for code reviewers who can take a look at
the non-Makefile files in
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jul9-nonattfiles
The base directory for code reviews is at:
http://cr.grommit.com/~chin/ksh93-webrev-jul9
FULL WEBREVS
All files:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jul9-allfiles
Makefiles:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jul9-makefiles
Non-AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jul9-nonattfiles
AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jul9-attfiles
INCREMENTAL WEBREVS
Current code vs. the codereview sent out July 2nd (final review round 1,
labelled June 29):
All files:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jun29vjul9-allfiles
Makefiles:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jun29vjul9-makefiles
non-AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jun29vjul9-nonattfiles
AST files:
http://cr.grommit.com/~chin/ksh93-webrev-jul9/jun29vjul9-attfiles
NOTES
There are a couple of files in the incremental webrevs (jul29vjul9)
that will show diffs that are due to changes in the gate, not due
to ksh93-related changes, due to a new bringover from the Nevada gate:
usr/src/cmd/Makefile.com
usr/src/lib/libc/sparc/Makefile
Same notes as listed in the pre-reviews:
https://www.opensolaris.org/jive/thread.jspa?threadID=32411&tstart=0
Plus this additional fix:
RFE: Update ksh93-integration tree per Peter Memishian's review comments
http://bugs.grommit.com/show_bug.cgi?id=293
Thanks,
April
