April Chin writes:
> In particular, we're looking for code reviewers who can take a look at
> the non-Makefile files in
> http://cr.grommit.com/~chin/ksh93-webrev-jul9/jul9-nonattfiles
Some notes:
- The usual way for handling non-working lint targets is to make
sure that the directory in question is not linted during a
'nightly' build (which is what $SRC/Makefile.lint is about).
Having non-working lint targets (as in $SRC/cmd/ksh/Makefile.com)
doesn't seem too helpful to me.
The current scheme works, but could be better.
- It'd be nice (though not required) to have helper scripts to do
the grunt work required during the build process. In particular,
$SRC/cmd/kes/Makefile.testshell is pretty hard to read, with a
bunch of escapes that are complicated by the fact that it's coded
in the middle of a makefile. Two or three lines are ok, but 58
lines seems like a lot.
- $SRC/cmd/sgs/libelf/Makefile.targ: why is a .WAIT needed before
$(ROOTDEMODIRS)? It looks like it should go with the rest of the
directory targets. (Probably just a nit.)
- The private libc buried in libast (unlinted, no less) is still
frightening. Not an issue to hold up integration, but I hope that
something better will be done in the future. Supporting more than
one libc in ON seems like a hazard.
- No changes were made to these files:
$SRC/lib/libcmd/amd64/Makefile
$SRC/lib/libcmd/i386/Makefile
$SRC/lib/libcmd/sparc/Makefile
$SRC/lib/libcmd/sparcv9/Makefile
Don't deliver unchanged files.
- $SRC/pkgdefs/Makefile: looks like a missed merge. (Not a code
review issue, but you'll want to clean it up before going for
RTI.)
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
