Mike Kupfer wrote: > >> The failure with path.sh was with BUILD_KSH93_AS_BINKSH=1. I only > >> tried it once. > > Roland> Can you try it again, preferably with B37 to avoid we're seeing > Roland> any "ghost" bugs caused by any > Roland> libc/libsocket/libnsl/libm/etc.-flag day or other kind of > Roland> disturbance ? > > I'll try again, though I probably won't get to it until after OSCon > (24-28 July).
;-( I guess you won't hit that issue again - see below... > >> either get the fix from upstream, or skip the test. > > Roland> Erm... the test is currently treated in a way which makes a > Roland> failure non-fatal. Isn't this enougth ? > > If the test failures are truly non-fatal, I could live with that, > especially since you're doing a good job of noting in Makefile.com which > tests are expected to fail. But my build died as a result of the test > failures. Maybe that was due to the failure in io.sh? Yes - because it wasn't marked as non-fatal before http://polaris.blastwave.org/changeset/330 ... starting with this commit a failure of the "io.sh" is no longer fatal (and with http://polaris.blastwave.org/changeset/336 I changed the test procedure a little bit to get "io.sh" working completely again (er... yes... I am cheating there... ;-/ ) because it fails early which may hide other, more serious problems). > >> We might even want to change cmd/ksh/Makefile.com so that "all" > >> doesn't depend on "testshell". > > Roland> Umpf... only if we can't resolve the failures this week, Ok ? I > Roland> would be very unhappy with loosing the tests as part of the > Roland> default build > > Yeah, I like the automated regression tests, too. I'm not sure that > "make all" is the right phase to run the tests, but it's not obvious to > me that "install" or "check" is any better. So, anyway, this would be a > last resort. What about creating a specialised "regresstest:" Makefile target for this purpose ? ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
