Gerd Hoffmann wrote: > Hi, > > >> Break it. It has just one user, our qemu, which is included in the same >> package. >> > > No, I'm hacking up one more user ;) > >
Nice. What will it do? > But maybe I'm better off shipping a private copy of kvmctl.c as long as > the library interface isn't finalized yet and subject to change. > > Yes. Patches to improve libkvm's interface so we can decouple it from qemu will be most welcome. >>> Thats why I went the route to additionally split the job kvm_create() >>> does into multiple, individually callable pieces. So I can first create >>> the vm, then create my custom memory slots (instead of the standard >>> setup built by kvm_create_userspace_memory()), then create the vcpu. >>> >>> >> That's exactly what's needed. >> >> The patch looks good, except that I wouldn't export >> kvm_create_default_phys_mem(). >> > > Fine with me. If you one uses the splitted versions, then for creating > a non-default memory layout, so there is no point in exporting that one. > > Should I send an updated patch or do you just drop these lines when merging? > Please send a rebased and retested patch. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
