Sebastian Herbszt wrote:

The AP enters HALT state with IF=0. What can make it resume at the
following "jmp 1b"? NMI? SMI?


Yes, but also INIT.

We might ignore IF=0 for hlt (which would be a bug).

I think i read something about a need for 4kb alignment for the
startup vector in the mp specs. AP_BOOT_ADDR is currently
at 0x10000 (16 x 4kb).


Yes, the SIPI address is 4K x sipi vector.

- Sebastian

--- rombios32start.S.orig Wed Aug  6 21:37:22 2008
+++ rombios32start.S Wed Aug  6 21:39:17 2008
@@ -40,6 +40,7 @@ _start:

  .code16
smp_ap_boot_code_start:
+  cli
  xor %ax, %ax
  mov %ax, %ds
  xor %eax, %eax
@@ -60,6 +61,7 @@ smp_ap_boot_code_start:
12:

  incw CPU_COUNT_ADDR
+  ljmp $0xe000, $(1f-_start)
1:
  hlt
  jmp 1b


Looks good.  Please post with signoff and changelog.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to