Anthony Liguori wrote:
+static int stgi_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
+{

It feels a little strange to see this here instead of an implementation of stgi/clgi in x86_emulate. Any reason for not going that route?


We already know the instruction is stgi, no need to go through the guest page tables to fetch it. We do the same thing for all instructions for which we have the length and all the information necessary to execute it.

GIF somehow needs exposure to userspace too, right? Otherwise, when using -no-kernel-apic, userspace may try to inject an interrupt when the guest cannot handle it, right?

Hmm, right, it needs to close the interrupt window.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to