Hi Suzuki,
> -----Original Message-----
> From: Suzuki K Poulose <suzuki.poul...@arm.com>
> Sent: Thursday, September 26, 2019 9:06 PM
> To: Jianyong Wu (Arm Technology China) <jianyong...@arm.com>;
> net...@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> m...@kernel.org; richardcoch...@gmail.com; Mark Rutland
> <mark.rutl...@arm.com>; Will Deacon <will.dea...@arm.com>
> Cc: linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> kvmarm@lists.cs.columbia.edu; k...@vger.kernel.org; Steve Capper
> <steve.cap...@arm.com>; Kaly Xin (Arm Technology China)
> <kaly....@arm.com>; Justin He (Arm Technology China)
> <justin...@arm.com>; nd <n...@arm.com>
> Subject: Re: [RFC PATCH v4 2/5] ptp: Reorganize ptp_kvm modules to make it
> arch-independent.
>
> Hi Jianyong,
>
> On 26/09/2019 12:42, Jianyong Wu wrote:
> > Currently, ptp_kvm modules implementation is only for x86 which
> > includs large part of arch-specific code. This patch move all of
> > those code into new arch related file in the same directory.
> >
> > Signed-off-by: Jianyong Wu <jianyong...@arm.com>
> > ---
> > drivers/ptp/Makefile | 1 +
> > drivers/ptp/{ptp_kvm.c => kvm_ptp.c} | 77 ++++++------------------
> > drivers/ptp/ptp_kvm_x86.c | 87
> ++++++++++++++++++++++++++++
> > include/asm-generic/ptp_kvm.h | 12 ++++
> > 4 files changed, 118 insertions(+), 59 deletions(-)
> > rename drivers/ptp/{ptp_kvm.c => kvm_ptp.c} (63%)
>
> minor nit: Could we not skip renaming the file ? Given you are following the
> ptp_kvm_* for the arch specific files and the header files, wouldn't it be
> good to keep ptp_kvm.c ?
>
If the module name ptp_kvm.ko is the same with its dependent object file
ptp_kvm.o, warning will be given by compiler,
So I change the ptp_kvm.c to kvm_ptp.c to avoid that conflict.
Thanks
Jianyong Wu
> Rest looks fine.
>
> Cheers
> Suzuki
