Oh ok. -Amit
On 4/22/16, 11:31 AM, "Luis Gomez" <[email protected]> wrote: >Hi Amit, the idea we discussed in the l2switch call is to combine both: >ofplugin patch to change features [1] + l2switch patch do deal with new plugin >[2]. For that we had to remove any feature change in [2]. > >[1] https://git.opendaylight.org/gerrit/#/c/35892/ >[2] https://git.opendaylight.org/gerrit/#/c/33303/ > >BR/Luis > >> On Apr 22, 2016, at 11:05 AM, Amit Mandke (ammandke) <[email protected]> >> wrote: >> >> @Sai - what happened to the pom and feature changes in this patch. I don’t >> see those anymore in the commit? How would this change in to Li feature? Am >> I missing something? >> >> -Amit >> >> >> From: Sai MarapaReddy <[email protected]> >> Date: Thursday, April 21, 2016 at 10:17 AM >> To: Amit Mandke <[email protected]> >> Cc: Luis Gomez <[email protected]>, Abhijit Kumbhare <[email protected]>, >> OpenDayLight-L2switch-Dev <[email protected]> >> Subject: Re: [L2switch-dev] L2switch Li issues >> >> @Amit/Abhijit - Agree with you, we will likely abandon patch. >> @Luis - I will rebase and push a patch so that it is ready for merge. >> >> Regards, >> Sai MarapaReddy >> >> On Thu, Apr 21, 2016 at 10:12 AM, Amit Mandke (ammandke) >> <[email protected]> wrote: >> Please abandon the patch on beryllium if decision is made to not change it. >> >> -Amit >> >> >> From: <[email protected]> on behalf of Luis Gomez >> <[email protected]> >> Date: Wednesday, April 20, 2016 at 7:31 PM >> To: Abhijit Kumbhare <[email protected]>, Sai MarapaReddy >> <[email protected]> >> Cc: OpenDayLight-L2switch-Dev <[email protected]> >> Subject: Re: [L2switch-dev] L2switch Li issues >> >> Correct, we will only change plugin in master, so we will only consider: >> https://git.opendaylight.org/gerrit/#/c/33303/ >> >> Also Sai, do you know why this patch says it cannot be merged? >> >> BR/Luis >> >> >>> On Apr 20, 2016, at 4:59 PM, Abhijit Kumbhare <[email protected]> wrote: >>> >>> Hi Sai, >>> >>> Please don't change the default on the stable/beryllium to the Li version. >>> We are only changing it to default in Boron. >>> >>> Thanks, >>> Abhijit >>> >>> On Wednesday, April 20, 2016, Sai MarapaReddy <[email protected]> >>> wrote: >>> Hi Luis, >>> >>> Following are the patches for Stable/beryllium & master for L2switch. I >>> have change feature.xml & pom.xml to correctly point the li version. >>> >>> Stable/beryllium - https://git.opendaylight.org/gerrit/#/c/33304/ >>> Master - https://git.opendaylight.org/gerrit/#/c/33303/ >>> >>> Could you please give it one more try with these patches ? >>> >>> Regards >>> Sai MarapaReddy >>> Brocade Communications >>> >>> On Fri, Apr 15, 2016 at 3:57 PM, Luis Gomez <[email protected]> wrote: >>> I think the table is more like this: >>> >>> Case 1: Current L2 switch (should point to OFP-He) & Current OFP (default >>> plugin is OFP-He) --> Should pass, current situation >>> Case 2: L2 switch with patch (should point to OFP-Li) & Current OFP >>> (default plugin is OFP-He) --> Should pass if current L2switch patch >>> contained all fixes for Li plugin. >>> Case 3: Current L2 switch (should point to OFP-He) & OFP with patch >>> (default plugin is OFP-Li, no -li features) --> Should pass if L2switch >>> did not care about OF plugin version >>> Case 4: L2 switch with patch (should point to OFP-Li) & OFP with patch >>> (default plugin is OFP-Li, no -li features) --> This will never work, you >>> are pulling -li features which do not exist anymore in OFP. >>> >>> I tested 2 & 3. >>> >>>> On Apr 15, 2016, at 2:42 PM, Sai MarapaReddy <[email protected]> >>>> wrote: >>>> >>>> Hi Luis, >>>> >>>> Please correct me if i am wrong here. >>>> >>>> You have checked below Case 3 & Case 4 and found errors. >>>> >>>> Case 3 errors :- >>>> https://jenkins.opendaylight.org/releng/view/l2switch/job/l2switch-csit-1node-switch-only-boron/291/robot/report/log.html >>>> Case 4 erros :- >>>> https://jenkins.opendaylight.org/releng/view/l2switch/job/l2switch-csit-1node-switch-only-boron/296/robot/report/log.html >>>> >>>> L2Switch Patch - https://git.opendaylight.org/gerrit/#/c/33304/ & >>>> https://git.opendaylight.org/gerrit/#/c/33303/ >>>> >>>> OFP Patch - https://git.opendaylight.org/gerrit/#/c/35892/ >>>> >>>> Current L2 switch code (with out patch ) points to features-openflowplugin >>>> which is equivalent to OFP-he >>>> >>>> Case 1: Current L2 switch (should point to OFP-He) & Current OFP (should >>>> point to OFP-He) --> Should pass >>>> Case 2: L2 switch with patch (should point to OFP-Li) & Current OFP >>>> (should point to OFP-He) --> Should Fail >>>> Case 3: Current L2 switch (should point to OFP-He) & OFP with patch >>>> (should point to OFP-Li) --> Should Fail >>>> Case 4: L2 switch with patch (should point to OFP-Li) & OFP with patch >>>> (should point to OFP-Li) --> Should Pass >>>> >>>> >>>> >>>> Regards, >>>> Sai Reddy >>>> Brocade Communications >>>> >>>> On Thu, Apr 14, 2016 at 4:03 PM, Luis Gomez <[email protected]> wrote: >>>> And this second test report is when I just apply ofplugin Li patch [2]: >>>> >>>> https://jenkins.opendaylight.org/releng/view/l2switch/job/l2switch-csit-1node-switch-only-boron/296/robot/report/log.html >>>> >>>> I see SAME issues as with l2switch Li plugin patch + some weird topology >>>> display issue (internal topology works as otherwise ping would not work >>>> but switch links are not shown) the second time we run Host Tracker test. >>>> >>>> BR/Luis >>>> >>>> [2] https://git.opendaylight.org/gerrit/#/c/35892/ >>>> >>>> >>>>> On Apr 13, 2016, at 7:32 PM, Luis Gomez <[email protected]> wrote: >>>>> >>>>> From today’s l2switch call, I got action point to run system test on Li >>>>> patch [1]: >>>>> >>>>> https://jenkins.opendaylight.org/releng/view/l2switch/job/l2switch-csit-1node-switch-only-boron/291/robot/report/log.html >>>>> >>>>> From the result above we can observe following issues: >>>>> >>>>> - Flow push: There is no LLDP flows being pushed. Also flood flows seem >>>>> to be in config space because operational shows flow ID. >>>>> - Address Tracker: All host IP addresses are seeing in all nodes, that is >>>>> not right, only node connected to host should show the host. >>>>> - Host Tracker: After remove/add OpenFlow port (ovs-vsctl add-port), no >>>>> host is learned anymore through that port. >>>>> - Loop Remover: Not working, using a loop topology, even when we observe >>>>> some ports are in DISCARD mode, mininet sees DUP packets. >>>>> >>>>> BR/Luis >>>>> >>>>> [1] https://git.opendaylight.org/gerrit/#/c/33303/ >>>>> >>>>> >>>> >>>> >>>> _______________________________________________ >>>> L2switch-dev mailing list >>>> [email protected] >>>> https://lists.opendaylight.org/mailman/listinfo/l2switch-dev >>>> >>>> >>> >>> >> >> > _______________________________________________ L2switch-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/l2switch-dev
