> http://cr.opensolaris.org/~gdamore/blk2scsa/
I won't have time to dig deep and verify logic, here's something that
caught the eye during a quick browse:
blk2scsa.h:
Would be nice to use enum for constants instead of #define: that way,
they would be included in CTF and make debugging (even) more pleasant.
blk2scsa.c:
142 static struct modlinkage modlinkage = {
143 MODREV_1, { &modlmisc, NULL }
This gotta be the only ON driver that uses {} syntax for linkage array :)
Have you considered adding warlock instrumentation? Most our SCSA
modules are warlockable individually and together
(framework+adapter+target).
-Artem
