I've updated the webrev, which includes both a merge against the current code, and a switch to enums. It doesn't include warlock support.
http://cr.opensolaris.org/~gdamore/blk2scsa/ -- Garrett Artem Kachitchkine wrote: > > > I didn't know that CTF debugging worked better for enums. > > Yeah, because it's a C type, whereas #defines are not part of C language. > >> I am always a bit uncomfortable using enums where I care about the >> value. > > You can assign specific values to enum members as long as they fit > into 'int'. > > enum { > XX = 123, > YY = 321, > >> Anyway, if there is pressure to do that, I could do so, but I don't >> want to stall this project on it at this time. Warlock isn't a tool >> I'm familiar with. > > If folks on storage-discuss don't speak up on this, consult internal > ssdg alias for the current rules. Warlock is easy to add and it pays > off down the road (as been proven many times). > > -Artem
