In LaszloEvents where you are adding the event name (105 and 219),  
the if clause is supposed to keep you from adding it every time you  
register, but you are testing a prop that you are not setting, so you  
will.  You either need to set the sender field too or test the name  
field.  Too bad we don't have support for simple compile-time  
expressions... (Gee, you could just pass them to rhino... hm...).

I'm thinking you probably want the sender and the event name anyways  
for profiling.  Presumably it will be more informative to log  
sender.event in your call/return, no?

Is there any benefit to logging a 'start' event too?  (I don't see a  
corresponding 'done' event).  I only did that for nodes because they  
are initialized asynchronously (so you can't log that in the call/ 
return because it will screw up the graph).

On 2006-03-14 12:27 EST, Jim Grandy wrote:

> Change 40569 by [EMAIL PROTECTED] on 2006/03/14 09:25:44 *pending*
>
>       Summary:Improved profiling for sendEvent, remove some flasm,  
> optimize a few basic calls
>       
>       Technical Reviewer: ptw (pending)
>       QA Reviewer: mdavis (pending)
>       Doc Reviewer:  (pending)
>       
>       Tests:runlzunit passes
>
> Affected files ...
>
> ... //depot/lps-dev/WEB-INF/lps/lfc/core/LzNode.as#30 edit
> ... //depot/lps-dev/WEB-INF/lps/lfc/events/LaszloEvents.as#16 edit
>
>
> <changeset-40569.zip>

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to