Thanks! I've made changes in response to this and will resend soon. On Mar 14, 2006, at 10:27 AM, P T Withington wrote:
> In LaszloEvents where you are adding the event name (105 and 219), > the if clause is supposed to keep you from adding it every time you > register, but you are testing a prop that you are not setting, so > you will. You either need to set the sender field too or test the > name field. Too bad we don't have support for simple compile-time > expressions... (Gee, you could just pass them to rhino... hm...). > Ouch, yeah, copy-paste error. I've changed the name of the attribute to _dbg_profileName (best to avoid conflicting with the debug name) and tested for it alone. > I'm thinking you probably want the sender and the event name > anyways for profiling. Presumably it will be more informative to > log sender.event in your call/return, no? > But then it would be hard to aggregate all event dispatches of a given name. The call graph tells you who the sender is, anyway, right? > Is there any benefit to logging a 'start' event too? (I don't see > a corresponding 'done' event). I only did that for nodes because > they are initialized asynchronously (so you can't log that in the > call/return because it will screw up the graph). > Thanks for the tip; I took that out. > On 2006-03-14 12:27 EST, Jim Grandy wrote: > >> Change 40569 by [EMAIL PROTECTED] on 2006/03/14 09:25:44 *pending* >> >> Summary:Improved profiling for sendEvent, remove some flasm, >> optimize a few basic calls >> >> Technical Reviewer: ptw (pending) >> QA Reviewer: mdavis (pending) >> Doc Reviewer: (pending) >> >> Tests:runlzunit passes >> >> Affected files ... >> >> ... //depot/lps-dev/WEB-INF/lps/lfc/core/LzNode.as#30 edit >> ... //depot/lps-dev/WEB-INF/lps/lfc/events/LaszloEvents.as#16 edit >> >> >> <changeset-40569.zip> > _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
