Not approved yet:

1) `extends Instance` can be left out, it is the default.

2) I thought we agreed that

   prototype.setters = { ... }

is better written as

   var setters = { ... }

?  (Same for _ignoreAttribute, defaultattrs, __LzDelayedSetters,  
earlySetters, getters.)

3) Please move the definitions mentioned in 2 back to their original  
vertical position in the file.  Also UIDs.

4) I will try to look at LPP-2399 soon, which may allow you to move  
the `if ($debug)`s back to their vertical position (but this won't be  
a gating factor).

Can you send me an updated change with 1-3 addressed?  Thanks.


On 2006-07-25, at 10:52 EDT, Philip Romanik wrote:

> (The changes are relative to lps/lfc/core)
>
> Change change.SzPhi4776.txt by [EMAIL PROTECTED] /tmp/ on 2006-07-25  
> 09:48:12 EDT
>
> Summary: Update core to use new class system. (actually, this only  
> updates LzNode.lzs)
>
> New Features:
>
> Bugs Fixed: LPP-2387
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> Tests: lzpix
>        lztest/lztest-node.lzx
>        smoke/simple.lzx
>
> Files:
> M      LzNode.lzs
> <patch.Philip.3920.tgz>

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to