After applying your patch, I get the following error in Firefox 1.5 mac dhtml debug:

missing ( before formal parameters
vacation-survey.l... (line 14)
Function.prototype.make = function Function.prototype.make () {

Debug is not defined
vacation-survey.l... (line 13)
null

So, I have to take back my approval :(

-Max

Max Carlson wrote:
Approved!

-Max

P T Withington wrote:
Change 20061107-ptw-G by [EMAIL PROTECTED] on 2006-11-07 17:25:34 EST
    in /Users/ptw/OpenLaszlo/legals-2

Summary: Name anonymous functions

Bugs Fixed:
LPP-2984  Add nice names for sprite methods in the profiler

Technical Reviewer: max (pending)
QA Reviewer: hqm (pending)
Doc Reviewer: n/a

Details:
    Revive old re-write code that looks for anonymous functions in
    assignments and uses the lhs expression text as the function
    name.

Tests:
    Inspected LFCdhtml-profile.js and noted that LzSprite methods all
    have names now.

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061107-ptw-G.tar

Reply via email to