This has screwed me a couple of times, too.
Should the script just always try to delete the change (and not fail)
before it adds it?
On 2006-11-22, at 16:16 EST, Benjamin Shine wrote:
The change tools do not handle updating change packages very well.
The second time you did svn-review, svn tried to re-add the tar of
your changes, but it couldn't because that file already existed in
svn. "svn add" can only happen once for each file in the repository.
Suggested workaround: if you submit a change for review, then want
to submit an updated change package, do this:
svn delete http://svn.openlaszlo.org/openlaszlo/patches/my-
nicepatch.tar
before you do svn-review the second time.
On Nov 21, 2006, at 5:36 PM, Sarah Allen wrote:
I don't understand why this line is necessary in the stop() method:
this.setAttribute("_flashstream", null); // temp hack for
video, otherwise playing is always true,
On Tue, Nov 21, 2006 at 2:13 PM, David Ungar wrote:
Change 20061121-ungar-E by [EMAIL PROTECTED] on 2006-11-21
14:07:09 PST
in /Users/ungar/src/svn/openlaszlo/trunk
Summary:
New Features:
Bugs Fixed:
LPP-3092 In mediastream, _setCam and _setMic need to send the
oncam and onmic events.
LPP-3091 no way to tell if a mediastream is broadcasting
LPP-3090 No way to mute the video on a particular stream
LPP-3089 No way to mute the audio on a particular stream
Technical Reviewer: sallen (pending)
QA Reviewer: tbd (pending)
Doc Reviewer: sallen (pending)
Documentation:
Added broadcasting attribute to see if stream is broadcasting.
(Implementation of same could be better by expanding possible
values of "mode".)
Added muteaudio and mutevideo attributes to check/set muting.
Added line of code to falsify "playing" attribute when stream
stops playing.
Added oncam and onmic event sending to setters.
Release Notes:
Details:
Tests:
test/video/test-muting-and-playing.lzx
Files:
A test/video/test-muting-and-playing.lzx
M lps/components/extensions/av/mediastream.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061121-
ungar-E.tar
