Not approved.

This part isn't right:

-                runtime = $runtime;
+                runtime = LzBrowser.getVersion();

LzBrowser.getVersion returns either the swf runtime version number or the DHTML browser 'User Agent' info. You want either `$runtime` or `canvas.runtime` -- they are synonyms. Again, I don't see the need to do the xpathquery to get the runtime value.

On 2007-03-29, at 18:07 EDT, Jim Grandy wrote:

Change 20070329-jgrandyw-D by [EMAIL PROTECTED] on 2007-03-29 15:05:40 PDT
    in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals2
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Little tweak as a tiny form of deferred gratification for Tucker

New Features:

Bugs Fixed:LPP-2996 - Explorer should use canvas attributes to fill in version info at bottom of navbar

Technical Reviewer: ptw
QA Reviewer:
Doc Reviewer:

Tests:WFM

Files:
M      laszlo-explorer/explore-nav.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070329- jgrandyw-D.tar

Reply via email to