Well, yes, I approve that part. I was concerned that you were trying
to sneak in something else along with this change. :)
On 2007-03-31, at 14:30 EDT, Jim Grandy wrote:
Let me give you a more restricted diff, then, that just addresses
the substance of the bug. The line you cited was incorrect, but the
change is also out of scope for this issue.
Index: laszlo-explorer/explore-nav.lzx
===================================================================
--- laszlo-explorer/explore-nav.lzx (revision 4544)
+++ laszlo-explorer/explore-nav.lzx (working copy)
@@ -1,7 +1,6 @@
<canvas width="200" height="605" bgcolor="0xeaeaea" debug="false">
<!-- Datasets -->
- <dataset name="sinfo" src="http:explorer-nav.lzx?lzt=serverinfo"
request="true" />
<dataset name="navdata"/>
<!-- Included Libraries -->
@@ -320,10 +319,9 @@
</method>
</basebutton>
<view x="10" y="570" layout="axis:y">
- <text resize="true" fgcolor="white"
font="smallfont,verdana,sans-serif" fontsize="8" text="${'Version:
' + canvas.version + ' (' + $runtime + ')'}" />
+ <text resize="true" fgcolor="white"
font="smallfont,verdana,sans-serif" fontsize="8" text="${'Version:
' + canvas.version + ' (' + canvas.runtime + ')'}" />
<view>
- <text fgcolor="white" font="smallfont,verdana,sans-serif"
fontsize="8" text="Build:"/>
- <text resize="true" fgcolor="white"
font="smallfont,verdana,sans-serif" fontsize="8" datapath="sinfo:/*/
@build"/>
+ <text fgcolor="white" font="smallfont,verdana,sans-serif"
fontsize="8" text="${'Build: ' + canvas.lpsbuild}"/>
<simplelayout axis="x"/>
</view>
</view>
On Mar 31, 2007, at 10:37 AM, P T Withington wrote:
Not approved.
This part isn't right:
- runtime = $runtime;
+ runtime = LzBrowser.getVersion();
LzBrowser.getVersion returns either the swf runtime version number
or the DHTML browser 'User Agent' info. You want either `
$runtime` or `canvas.runtime` -- they are synonyms. Again, I
don't see the need to do the xpathquery to get the runtime value.
On 2007-03-29, at 18:07 EDT, Jim Grandy wrote:
Change 20070329-jgrandyw-D by [EMAIL PROTECTED] on
2007-03-29 15:05:40 PDT
in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals2
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: Little tweak as a tiny form of deferred gratification
for Tucker
New Features:
Bugs Fixed:LPP-2996 - Explorer should use canvas attributes to
fill in version info at bottom of navbar
Technical Reviewer: ptw
QA Reviewer:
Doc Reviewer:
Tests:WFM
Files:
M laszlo-explorer/explore-nav.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070329-
jgrandyw-D.tar
