Okay, committed in devildog.
On Jan 27, 2008, at 3:38 PM, P T Withington wrote:
Yes let's make that change. If getProp was private, I see no reason
to keep it.
On 2008-01-26, at 19:10 EST, Donald Anderson wrote:
Phil, Henry,
In core/LzNode.lzs, in devildog branch, this line is commented:
//prototype.getProp = getAttribute;
Not so in trunk. This appears to be part of r7519.
Could be that getProp is now gone (it was private, so
no doc issue) and that getAttribute could be used instead.
Indeed, I changed LaszloView.lzs, where the reference to
getProp is made, and got lzpix to work to DHTML again.
Henry, is this an appropriate fix?
- Don
$ svn diff views/LaszloView.lzs
Index: views/LaszloView.lzs
===================================================================
--- views/LaszloView.lzs (revision 7879)
+++ views/LaszloView.lzs (working copy)
@@ -2079,11 +2079,11 @@
if (prop == "x" || prop =="y" ){
tLink.update ( prop );
- return tLink.offset[prop] + tLink.scale[prop] *
this.getProp( prop );
+ return tLink.offset[prop] + tLink.scale[prop] *
this.getAttribute( prop );
}else if ( prop == "width" || prop == "height" ){
var axis = prop == "width" ? "x" : "y"
tLink.update ( axis )
- return tLink.scale[axis] * this.getProp( prop );
+ return tLink.scale[axis] * this.getAttribute( prop );
}else{
//not yet implemented: rotation, alpha...
On Jan 26, 2008, at 5:59 PM, Philip Romanik wrote:
I'm seeing errors as well.
You won't see errors in swf7/8, but you'll see errors in dhtml.
Run with firebug and the next error you'll see is 'this.getProp is
not a function' when you click on an image.
Phil,
Just sent a fix to review -- Running lzpix, I don't get errors,
and if I click
on one of the top pictures, I get the set of pictures
to show, but if I click on one, I get no action.
Do you see the same now? What is the method to debug this?
- Don
On Jan 25, 2008, at 5:00 PM, Philip Romanik wrote:
This fixed weather, but demos like lzpix are still broken. If I
run lzpix in dhtml/debug it runs, although you'll see errors if
you start clicking on images. In non-debug mode you get an
LzCanvas not defined, and a new error (shown twice):
missing ) in parenthetical
var $8=this.defaultattrs;var $9=("$refs"in$8)&&$8.$refs;var
$10=null;for(var $11...
LFCdhtml.js (line 349)
Change 20080125-dda-o by [EMAIL PROTECTED] on 2008-01-25 14:06:29
EST
in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
for http://svn.openlaszlo.org/openlaszlo/branches/devildog
Summary: SWF9: fix unparser problem in inserting spaces
New Features:
Bugs Fixed: LPP-5234
Technical Reviewer: ptw (pending)
QA Reviewer: promanik (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
Errors reported by Phil with LzCanvas not defined.
We believe this is an unparsing bug. The new unparser adds
annotations to the text (with line number, class info) that is
eventually removed. So any code that examines unparsed strings
must 'unannotate' to see the clear text string.
The weather demo that Phil noticed this error in for DHTML works
fine for me (in DHTML and SWF8) before and after the fix, so I'm
not 100% this will completely fix the error he is seeing, but it
seems likely given the description.
Tests:
demo/weather
SWF8+DHTML
smokecheck
SWF8+DHTML (1 failure for SWF8, which was there previously)
swf9/hello
Files:
M WEB-INF/lps/server/src/org/openlaszlo/sc/
ParseTreePrinter.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080125-dda-o.tar
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
