Not approved. Ant lztest shows some warnings and I think you missed a
few spots in CanvasCompiler and LzDataProvider. Your change also
exposed a bug in LaszloCanvas.
I'll send a follow change out for review that fixes these issues.
P T Withington wrote:
Change 20080521-ptw-z by [EMAIL PROTECTED] on 2008-05-21 17:21:13
EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Rename `ConstructorMap` to `lz`, don't clobber `lz` if it
already exists.
Bugs Fixed:
LPP-6020 'DHTML compiler should check to see if window.lz hash is
defined before overwriting it.'
Technical Reviewer: max (pending)
QA Reviewer: promanik (pending)
Release Notes:
Details:
*: ConstructorMap -> lz
LzDefs: Remove private ConstructorMap. Don't create a hash in lz
if it already exists.
LaszloInitiator: Remove stale comment.
ParseTreePrinter: Define missing 'is' operator in op table,
discovered while developing this patch.
Tests:
ant lztest, smokecheck
Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/core/LzDefs.lzs
M WEB-INF/lps/lfc/glue/LaszloInitiator.lzs
M WEB-INF/lps/lfc/views/LzScript.lzs
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/helpers/LzState.lzs
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataRequest.lzs
M WEB-INF/lps/lfc/data/LzDataProvider.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080521-ptw-z.tar
--
Regards,
Max Carlson
OpenLaszlo.org
