I was seeing warnings like this:
[exec] Compiling: test/lztest/lztest-node.lzx to
test/lztest/lztest-node.js
[exec] js: "lps/includes/lfc/LFCdhtml-debug.js", line 13350:
uncaught JavaScript runtime exception: ReferenceError: "ConstructorMap"
is not defined.
[exec] js: "lps/includes/lfc/LFCdhtml-debug.js", line 11194:
uncaught JavaScript runtime exception: TypeError: Cannot call method
"getInitArg" of undefined
[exec] js: "tmp/test_lztest_lztest-node.js", line 83: uncaught
JavaScript runtime exception: TypeError: Cannot call method "sendEvent"
of undefined
[exec] FAILED a test in runlztest.sh: test/lztest/lztest-node.lzx
Also, swf9 failed to compile:
[java] ERRORS:
[java] [/tmp/lzswf9/lzgen11247/LFCApplication.as: 95] line
unknown: Error: Access of undefined property ConstructorMap.
[java] FAIL: compiler returned 1
[java] Done executing compiler
[java] Intermediate file /tmp/lzswf9/lzgen11247/app.swc: does not
exist
[java] Exception compiling scriptfile:
org.openlaszlo.sc.CompilerError: line unknown: Error: Access of
undefined property ConstructorMap, in line:
ConstructorMap[LzDataProvider.tagname] = LzDataProvider;
[java] org.openlaszlo.sc.CompilerException:
org.openlaszlo.sc.CompilerError: line unknown: Error: Access of
undefined property ConstructorMap, in line:
ConstructorMap[LzDataProvider.tagname] = LzDataProvider;
[java] at org.openlaszlo.sc.Compiler.compile(Compiler.java:386)
[java] at org.openlaszlo.sc.lzsc.compile(lzsc.java:110)
[java] at org.openlaszlo.sc.lzsc.compile(lzsc.java:322)
[java] at org.openlaszlo.sc.Main.main(Main.java:10)
[java] Compilation aborted.
I just sent you an updated change for review that fixes the issues. The
CanvasCompiler needed to use 'new lz.canvas' to init the canvas instead
of 'new LzCanvas'. It also fixes the bogus lookup in LzDataProvider.
P T Withington wrote:
What warning are you seeing in `ant lztest`? I don't see any.
Can you give me more info on what you mean about CanvasCompiler and
LzDataProvider? They do not contain the word ConstructorMap in my world.
On 2008-05-21, at 18:40 EDT, Max Carlson wrote:
Not approved. Ant lztest shows some warnings and I think you missed a
few spots in CanvasCompiler and LzDataProvider. Your change also
exposed a bug in LaszloCanvas.
I'll send a follow change out for review that fixes these issues.
P T Withington wrote:
Change 20080521-ptw-z by [EMAIL PROTECTED] on 2008-05-21
17:21:13 EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Rename `ConstructorMap` to `lz`, don't clobber `lz` if it
already exists.
Bugs Fixed:
LPP-6020 'DHTML compiler should check to see if window.lz hash is
defined before overwriting it.'
Technical Reviewer: max (pending)
QA Reviewer: promanik (pending)
Release Notes:
Details:
*: ConstructorMap -> lz
LzDefs: Remove private ConstructorMap. Don't create a hash in lz
if it already exists.
LaszloInitiator: Remove stale comment.
ParseTreePrinter: Define missing 'is' operator in op table,
discovered while developing this patch.
Tests:
ant lztest, smokecheck
Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/core/LzDefs.lzs
M WEB-INF/lps/lfc/glue/LaszloInitiator.lzs
M WEB-INF/lps/lfc/views/LzScript.lzs
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/helpers/LzState.lzs
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataRequest.lzs
M WEB-INF/lps/lfc/data/LzDataProvider.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20080521-ptw-z.tar
--
Regards,
Max Carlson
OpenLaszlo.org
--
Regards,
Max Carlson
OpenLaszlo.org
