Ah, good point!

Henry, I see you added this line to LzSprite.js as part of r14262:
if ($debug || this.capabilities.accessibility) {
     // annotate divs with sprite IDs, but don't override existing IDs!
     ...
}

I'll move the part that sets the div's id to setAADescription() instead...

André Bargull wrote:
> In LaszloView.lzs:
>> +    if ($debug || this.capabilities.accessibility) {
>> +        if (this.capabilities.setid) 
>> this.sprite.setID(this._dbg_name());
>> +    }
> Is "_dbg_name()" defined at all in non-debug mode? Because if it isn't 
> defined and you compile in non-debug mode with accessibility turned on, 
> the id won't be set properly.
> 
> 
> 
> On 7/24/2009 12:11 AM, Max Carlson wrote:
>> Change 20090723-maxcarlson-v by maxcarl...@bank on 2009-07-23 
>> 15:02:38  PDT
>>      in /Users/maxcarlson/openlaszlo/trunk-clean
>>      for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Improve div IDs for DHTML in debug mode
>>
>> Bugs Fixed: LPP-8264 - No OL debugger in IE7, DHTML with webtop  
>> wrapper page
>>
>> Technical Reviewer: ptw
>> QA Reviewer: hminsky
>>
>> Details: swf/LzSprite.as, swf9/LzSprite.as - Set capabilities.setid 
>> to  false.
>> dhtml/LzSprite.js - Set capabilities.setid to true.  Define setID() 
>> to  set the sprite div's ID.
>> LzTextSprite.js, LzInputTextSprite.js - Define setID() to set the  
>> sprite div's ID.
>> LaszloView.lzs - Set sprite ids if debug mode is on or accessibility  
>> is on or  capabilities.setid is true
>>
>> Tests: DHTML DOM is much easier to debug - sprite relationships to 
>> LZX  are much clearer.
>>
>> Files:
>> M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
>> M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>> M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>> M      WEB-INF/lps/lfc/views/LaszloView.lzs
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20090723-maxcarlson-v.tar
>> _______________________________________________
>> Laszlo-reviews mailing list
>> [email protected]
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
>>
>>   

-- 
Regards,
Max Carlson
OpenLaszlo.org

_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to