Change 20091118-maxcarlson-s by maxcarl...@bank on 2009-11-18 10:55:10 PST
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED AGAIN: Improve CSS sprites

Bugs Fixed: LPP-8622 - DHTML: Combine all css sprites into a single large image

Technical Reviewer: hminsky
QA Reviewer: ptw

Details: Update includes usemastersprite option to disable master sprites if 
necessary.

LzKeyboardKernel - Use LzSprite.__rootSprite.options to look for the 
cancelkeyboardcontrol option.

LzInputTextSprite - Use LzSprite.blankimage for the URL to blank.gif.

LzSprite - When quirks.use_css_master_sprite is on, store a path to the
master sprite and preload a copy of it.  setResource() looks for a
spriteoffset, and where available uses it as the y offset in the master
sprite.  Set the CSS y offset in __setBGImage() and __setFrame().  Process 
options hash from lz.embed.dhtml(), use  LzSprite.blankimage for the URL to 
blank.gif, 

ImageMontageMaker - Refactor to build horizontal or vertical image strips.  
Allow spacing between images to be compacted.

FileUtils - Fix error in path processing.

DHTMLWriter - Track all resources added to the app, then build a single master 
CSS sprite image.

embed-body* - Add default values for all properties available to 
lz.embed.dhtml()

embednew.js - Add usemastersprite option, simplify handling of options passed 
to the LFC.

lps/admin/dev-console* - Recompile dev console to use master sprite

Tests: Now, only stretched resources need to be loaded at runtime.  This cuts 
the number of HTTP requests in half in many cases, e.g. webtop went from ~144 
to ~72 requests with an empty cache.  Image retrieval time is also improved, 
and the DOM is simpler with fewer img objects.

Files:
M       WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M       WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M       WEB-INF/lps/server/src/org/openlaszlo/media/ImageMontageMaker.java
M       WEB-INF/lps/server/src/org/openlaszlo/utils/FileUtils.java
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java
M       WEB-INF/lps/templates/embed-body_jp.xslt
M       WEB-INF/lps/templates/embed-body.xslt
M       lps/includes/source/embednew.js
M       lps/admin/dev-console.lzx.js
A       lps/admin/dev-console.sprite.png
M       lps/admin/dev-console.lzx.swf

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20091118-maxcarlson-s.tar

_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to