This change was made because we can no longer rely on instances having a constructor.tagname property that can be looked up later to instantiate a copy.
On 1/5/10 7:10 PM, Henry Minsky wrote: > What was the reason that we wanted to make this change? > > > On Tue, Jan 5, 2010 at 8:59 PM, Max Carlson <[email protected] > <mailto:[email protected]>> wrote: > > Change 20100105-maxcarlson-T by maxcarl...@bank on 2010-01-05 > 14:09:06 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED AGAIN: Fix lz/list.lzx to use correct methods for > instantiating new items > > Bugs Fixed: LPP-6002 - lztextlistitem warning/errors of undefined > properties (title, height, setAttribute), LPP-8690 - Update > components to use class references directly instead of tagnames > (partial) > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: This has turned into a pretty hairy API-breaking change > fairly quickly... Perhaps we should rethink correcting tagname? > > Rename *classname to *class. *class attribute now contains a > reference to the class that should be created dynamically. Directly > instantiate classes, instead of looking up by tagname first. > > Tests: Testcase from LPP-6002 no longer warns, component_sampler.lzx > continues to work. lzunit-basedatacombobox.lzx runs as before. > > Files: > M test/components/base/lzunit-basedatacombobox.lzx > M lps/components/lz/tabslider.lzx > M lps/components/lz/radio.lzx > M lps/components/lz/list.lzx > M lps/components/lz/tabs.lzx > M lps/components/base/basetabelement.lzx > M lps/components/base/basecombobox.lzx > M lps/components/base/basetabslider.lzx > M lps/components/base/baselist.lzx > M lps/components/base/basetabs.lzx > M lps/components/base/basedatacombobox.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100105-maxcarlson-T.tar > > > > > -- > Henry Minsky > Software Architect > [email protected] <mailto:[email protected]> > > -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
