Approved!
I've noted three other things comparing the base explore-nav.js file
with your changed version. (This is unrelated to your change, they're
compiler issues):
1) two semicolons are emitted for top level statements
var navdata=null;;var treecontainer=null;;var browser=null;;
lz.colors.offwhite=15921906;;lz.colors.gray10=1710618;;lz.colors.gray20=3355443;;
2) some resource dimensions are floating point numbers instead of integers:
LzResourceLibrary.navbg={ptype:"ar",frames:['images/nav_bg.png'],width:200.0,height:600.0,spriteoffset:189};
3) there is a stray curly bracket before some Class.make statements:
lz.colors.ltblue=14540287;;lz.colors.ltgreen=14548957;;{
Class.make("$lzc$class_basefocusview"
Are these issues already known? Otherwise a bug report should be filed,
because they unnecessarily increase file size.
On 5/20/2010 2:23 AM, Max Carlson wrote:
I'm checking this in ahead of review.
Change 20100519-maxcarlson-F by maxcarl...@friendly on 2010-05-19 15:07:38 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Fix laszlo-explorer in IE 8 DHTML
Bugs Fixed: LPP-9003 - DHTML: right click throws exception (IE8)
Technical Reviewer: [email protected]
QA Reviewer: ptw
Details: Updated to address Andre's comments:
1) wrong path for excanvas include
<script type="text/javascript" src="/trunk-clean/lps/includes/excanvas.js">
Fixed.
2) splice(1) and splice(1,1) are different things
- splice(i) returns all elements starting at index i (inclusive)
- splice(i,n) returns n elements starting at index i (inclusive)
You actually want: 'seq.splice(1, seq.length - 1)'
Fixed.
3) validateReferenceDependencies() is only needed in contextmenu.js, because
it's compiled with the -g option. Is this necessary at all? It seems to be more
correct to remove the -g option when compiling contextmenu.lzx
This is discussed at http://jira.openlaszlo.org/jira/browse/LPP-9017
Otherwise, the same:
LzRuntime - since WEB-INF/lps/lfc/contextmenu is essentially an LZO, it
includes code for verifying reference dependencies - which won't work when
included as part of the DHTML LFC. Add a stub version for non-debug mode.
explore-nav.lzx - Add explicit second argument to Array.splice() for
compatibility in IE DHTML.
index.html - Move LFC include to body, add conditional include for excanvas for
IE.
explore-nav* - Recompile explore-nav SOLO apps
Tests: explore-nav/index.html?lzr=dhtml now works properly in IE DHTML, other
browsers show the context menu when the explore app is right-clicked.
Files:
M WEB-INF/lps/lfc/compiler/LzRuntime.lzs
M laszlo-explorer/explore-nav.swf8.swf
M laszlo-explorer/explore-nav.js
M laszlo-explorer/explore-nav.sprite.png
M laszlo-explorer/explore-nav.swf10.swf
M laszlo-explorer/index.html
M laszlo-explorer/explore-nav.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100519-maxcarlson-F.tar
