On 2010-05-21, at 06:52, André Bargull wrote:
> Approved!
>
>
> I've noted three other things comparing the base explore-nav.js file with
> your changed version. (This is unrelated to your change, they're compiler
> issues):
>
> 1) two semicolons are emitted for top level statements
>> var navdata=null;;var treecontainer=null;;var browser=null;;
>> lz.colors.offwhite=15921906;;lz.colors.gray10=1710618;;lz.colors.gray20=3355443;;
Henry recently added a spare semi-colon in his chunking work, but I don't think
the lzo's go through that path, so this is probably just the unparser being
stupid.
> 2) some resource dimensions are floating point numbers instead of integers:
>> LzResourceLibrary.navbg={ptype:"ar",frames:['images/nav_bg.png'],width:200.0,height:600.0,spriteoffset:189};
This may be because resources are not going through the compressor.
> 3) there is a stray curly bracket before some Class.make statements:
>> lz.colors.ltblue=14540287;;lz.colors.ltgreen=14548957;;{
>> Class.make("$lzc$class_basefocusview"
This may be because the source statement was in a block (possibly scoping a
#pragma or compile-time conditional) and the unparser is not smart enough to
know the block is unnecessary.
> Are these issues already known? Otherwise a bug report should be filed,
> because they unnecessarily increase file size.
Can you file a bug for each of these? The unparser is pretty sloppy and
probably responsible for each of these problems, but we should track them
separately.
