Not approved. I see extra (white) borders being drawn - see demos/house.lzx. Shouldn't they be drawn with zero-alpha?

Also, can you reuse the background/border drawing code that's already in drawBackground()? I worry about skew as these methods get out of sync...

On 12/4/10 8:04 PM, Henry Minsky wrote:
Change hqm-20101204-2SZ by [email protected] on 2010-12-04 22:53:54 EST
     in /Users/hqm/openlaszlo/trunk3
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: make drop shadow on LzSprite apply to the bounding box, not the child 
objects

New Features:

Bugs Fixed: LPP-9494

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Overview:


Details:

If bgcolor is null or background is hidden, create a dedicated filled
child Sprite with the shape of the LzSprite's bounding box, and apply
the shadow filter to it in order to get the glow around the bounding
box. Use the knockout feature of the shadow filter to make the shadow
sprite transparent.


Tests:

See testcase "shadow.tar" in bug report. This has buttons in a buttogroup, 
which have radiused corners.

The glow from the focus shadow should look like it does in DHTML, with
glow applied around the whole button's bounding box, not to the text
outline or icon inside the button.



Files:
M       WEB-INF/lps/lfc/kernel/swf9/LzSprite.as


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20101204-2SZ.tar

Reply via email to