On Thu, Nov 26, 2009 at 8:28 PM, Graham Binns <[email protected]> wrote: > 2009/11/26 Michael Hudson <[email protected]>: >> Jeroen Vermeulen wrote: >>> Michael Hudson wrote: >>> >>>> I changed how shutting down works in >>>> >>>> http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9939 >>>> >>>> but the code looks correct to me :/ I guess I'll --postmortem something >>>> today and see what the value of 'really_shutdown' is... >>> >>> Looks like a misunderstanding with the interpreter. As an experiment, I >>> tried: >>> >>> def foo(x): >>> try: >>> return x >>> except Exception, e: >>> print e >>> else: >>> print "Or else." >>> >>> foo(10) >>> >>> >>> In python 2.4, 2.5, or 2.6 this just prints 10. The "else" block >>> attached to the "try" is never executed. >> >> Aarargh. I knew this would be a bad week to stop drinking coffee :-) >> >> Having found the problem, it would have been easy to fix though? >> > > Jeroen's got a fix for it. I'm going to review it in the morning > unless you want to do it first ;) >
I've just review a patch that Michael submitted to land it. jml _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
