On Mon, 2010-08-16 at 22:27 +0100, Julian Edwards wrote: > On Monday 16 August 2010 19:24:56 Guilherme Salgado wrote: > > > > Each policy sets can_upload_source, can_upload_binaries and > > > > can_upload_mixed, but you have to set the first two to True to have the > > > > last checked, meaning that all three would be acceptable. > > > > > > Maybe we could get rid of these 3 settings and create a separate one > > > (e.g. upload_types) using an Enum that describes the types of uploads a > > > given policy accepts? That may not work well if we have more than a > > > handful combinations of upload types accepted by all the policies, > > > though. > > > > This is the specific bit where I'd like your opinion, Julian. > > Hi Salgado > > The enum might be problematic as I believe these are non-exclusive flags. > > In Soyuz, we actually no longer accept mixed uploads; this is a relic of the > old security policy which allowed binaries to be built in secrecy elsewhere > and then uploaded with the source later when effectively "unembargoing" them.
And that means we don't need to accept binary-only uploads on the security policy either, right? If that's the case then the flags seem to be, in practice, exclusive. Here's what we have now: insecure: source-only buildd: binary-only sync: source-only security: source-only, binary-only and mixed (although this should become source-only AIUI) recipe: source-only 'anything': the name says it all, but it's used just for tests and none of our tests do mixed uploads anymore. We could replace, then, the 3 attributes with a single enum and simplify things a bit, but I'm not sure whether or not we'll want policies accepting mixed uploads to accept source-only or binary-only uploads (in which case the enum wouldn't make much sense, I think). What do you guys think? -- Guilherme Salgado <https://launchpad.net/~salgado>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
