On Tue, 2010-08-24 at 08:34 +0100, Julian Edwards wrote: > On Monday 23 August 2010 21:44:01 Guilherme Salgado wrote: > > And that means we don't need to accept binary-only uploads on the > > security policy either, right? > > The security policy is redundant, we can remove it entirely.
I've got a branch which removes it: https://code.edge.launchpad.net/~salgado/launchpad/remove-security-upload-policy/+merge/33581 There were two tests which seem to be testing mixed-uploads to the security pocket, so I've removed them. Can you double check that we're not losing any test coverage because of that? > > > 'anything': the name says it all, but it's used just for tests and > > none of our tests do mixed uploads anymore. > > There's also 'absolutely-anything'. > > > We could replace, then, the 3 attributes with a single enum and simplify > > things a bit, but I'm not sure whether or not we'll want policies > > accepting mixed uploads to accept source-only or binary-only uploads (in > > which case the enum wouldn't make much sense, I think). What do you guys > > think? > > I think it can be reduced to a bool! But a 2-state enum is more future proof. Here it is: https://code.edge.launchpad.net/~salgado/launchpad/vostok-upload-policy/+merge/33584 Much simpler, and now with unit tests -- the kind that runs fast, even. -- Guilherme Salgado <https://launchpad.net/~salgado>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
