Review: Approve code
This branch looks good. I had a couple of small questions/suggestions:
On line 83 of the diff, I don't understand why the outer parenthesis
exist on the right hand side of the equals:
self._count_recipients = (len(self._all_recipients))
It would be nice if the tests in
lib/lp/registry/browser/tests/test_person_contact.py were arranged in
smaller test cases instead of one big test case per class.
--
https://code.launchpad.net/~sinzui/launchpad/team-without-admin/+merge/136274
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
