On 11/26/2012 04:47 PM, Benji York wrote: > Review: Approve code > > This branch looks good. I had a couple of small questions/suggestions: > > On line 83 of the diff, I don't understand why the outer parenthesis > exist on the right hand side of the equals: > > self._count_recipients = (len(self._all_recipients))
The outer parens are cruft from the old code. I will remove them. > It would be nice if the tests in > lib/lp/registry/browser/tests/test_person_contact.py were arranged in > smaller test cases instead of one big test case per class. I will break these down. -- Curtis Hovey http://launchpad.net/~sinzui https://code.launchpad.net/~sinzui/launchpad/team-without-admin/+merge/136274 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
