On Tue, 2007-07-03 at 03:05 -0500, Jesus Reyes A. wrote:
> ----- Original Message -----
> From: "Joost van der Sluis" <[EMAIL PROTECTED]>
> To: <lazarus@miraclec.com>
> Sent: Saturday, June 30, 2007 1:58 PM
> Subject: Re: [lazarus] Subrows in grids...
>
>
> > On Wed, 2007-06-20 at 17:51 -0500, Jesus Reyes wrote:
> [snip]
> >> Looks nice!
> >>
> >> About the patch, I just applied and didn't take a closer look, will
> >> try to do later, initially there seems to be many problems for
> >> example, the TStringGrid editor doesn't know about subrows, and
> >> crashed my lazarus badly, I also wasn't able to reproduce your image,
> >> if issues are fixed I think we should add it.
> >
> > Here is a new patch. This one works better.
>
> AV's are fixed, but I'm afraid it's still not ready, I been testing and
> found many issues will list only (IMO) the two most important.
Yes, it's not ready at all... But the problems are problems for the
programmer, not the end-user.
> 1. Gaps are not redrawn, gaps are formed under various circunstances: using
> SubRowCount without custom columns, columns with different sizes (very
> common in dbgrid), etc. This might be a little difficult to get it working
> right.
Yes, I already mentioned this in my first mail about this feature.
> 2. It doesn't work with fixed columns, I guess in multi subrow grid, cells
> in fixedrows zone should automatically use SubRowCount*DefaultRow height,
> this issue doesn't allow a dbgrid to work/look ok too.
It worked here, except from some problems with fixed columns which were
also present without this patch. I'll have a look.
> Maybe the feature is not intented to work under all circunstances but in
> that case, I guess SubRowCount should do nothing if there are no custom
> columns or only work if at least one column has SpanSubrows>1, or vice
> versa.
Yes, I think it's impossible to make this work in all cases. As a
programmer you should know that using a subrowcount of 2, and a fixed-
column setting of 3 is impossible. Otoh we can build checks for that.
If SubRowCount=1, nothing will happen. (At least, that was my intention)
Joost
ps: I'll have a look at your project.
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
