On Fri, 2005-02-04 at 08:07 +0100, Kai-Uwe Behrmann wrote:

> As X is an large project, I prefere to ask You in the first place.
> Would You mind to rename the typedef BOOL in the lcms header?

This is a good opportunity for me to chime in. I am working on
implementing the msmcs api in Wine on top of Lcms. So I stumbled
on this problem too, because in Wine of course all common Windows
types (DWORD, BYTE, BOOL, LPSTR, ...) are already defined.

And I can't set NON_WINDOWS to 0 because I need the build to work
with the header installed on non-Windows systems, over which I
don't have any control.

The workaround I made looks like this for DWORD:

#define DWORD   LCMS_DWORD

#ifdef HAVE_LCMS_H
#include <lcms.h>
#endif

#undef DWORD
#define DWORD   DWORD

Which is rather ugly IMO. It would be much nicer if lcms.h
would itself be able to detect if the types need to be defined.
It would also be nice if no editing is needed for the header to be
useable on Windows and non-Windows systems.

Anyway, thank you for Lcms!

 -Hans




-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Lcms-user mailing list
Lcms-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lcms-user

Reply via email to