On Wed, 2006-03-29 at 15:23, Charles Steinkuehler wrote: > Mike Noyes wrote: > > Pending: > > * feedback on shell code in doc-build.sh > > I finally got a few free minutes to look at this.
Charles, Thank you for helping. :-) > Your script looks very clean except for one issue with the check_errors > function. You're removing the lockfile in this routine, which is > required for expected operation if one of the document building commands > fails. You are also using the check_errors procedure for testing > whether the lockfile generation worked or not. That means if you run > this script while another instance is already running, it will not be > able to grab the lockfile, but will then forcibly remove the lockfile > without owning it (a BadThing :). > > It looks like the easiest way to handle this is to special case the > create_lockfile error checking (ie: put the logic inside the > create_lockfile function). If you want the lockfile forcibly grabbed > after some amount of time (ie: 8 to 24 hours or so...something that's > much longer than document generation should normally take), you can do > this with the -l switch, ie: > > lockfile -l 72000 ... > > would force removal of any existing lockfile older than 20 hours. Ok. I made the changes in doc-build.sh r1.8. I hope I did it correctly. -- Mike Noyes <mhnoyes at users.sourceforge.net> http://sourceforge.net/users/mhnoyes/ SF.net Projects: leaf, phpwebsite, phpwebsite-comm, sitedocs ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ leaf-devel mailing list leaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/leaf-devel
