Hi Andreas,
thanks for sharing your work. The script and the tutorial look great and
I will add a link to your tutorial on the Lensfun homepage at
http://lensfun.sourceforge.net/calibration/.
I would keep the decision to update the existing calibration script in
the Lensfun repo up to Torsten Bronger who created and maintained it. As
Torsten's tutorial is based on the script in the current Lensfun sources
we probably cannot simply replace it. But let's wait and hear his
opinion about that...
From my point of view it is nothing wrong with having your script in
your separate Gitlab repo for now. This assures that it is regularly
updated, maintained and kept in sync with the tutorial. Having these
tools and scripts too tightly coupled into the library sources might not
be (and might not have been) the best solution for the long run as it
complicates maintenance for a small core team. Right now I would say the
Lensfun project has something like 0.25 active developers :)
Anyway... Thanks again for your contribution! :)
Sebastian
On 15.11.18 12:32, Andreas Schneider wrote:
Hello,
[resend without the patch attached, might be too big for the ml]
I've rewritten the lensfun calibration script from scratch. I don't find the
current script very user friendly. Also it uses dcraw which gets updates only
rarely. Also the current calibrate.py is spaghetti code. I find it hard to
understand. It has also issues with reading exif data e.g. for Nikon lenses.
I rewrote the script from scratch using python3-exiv2 for reading exif data
which can deal with lens numbers and get a human readable presentation. I've
used darktable-cli for creating tif and ppm files. It supported my camera
shortly after it was released. I store everything in ini file as python
provides functions to write and read them.
Currently it is developed here:
https://gitlab.com/cryptomilk/lens_calibrate
A patch to add it to the lensfun repository is available here:
https://xor.cryptomilk.org/patches/0001-tools-Add-new-lens_calibrate.py-script.patch
if you prefer that. I would delete my repo then. As lensfun is GPLv3 I
licensed the new script under the same license.
Also I have written a completely new detailed tutorial for lens calibration.
It is be ready to be released on https://pixls.us/ if that is OK.
A copy of the article can be found here:
https://hackmd.io/s/SkOIRlr5z
Feedback is very welcome.
Thanks,
Andreas
_______________________________________________
Lensfun-users mailing list
Lensfun-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lensfun-users
_______________________________________________
Lensfun-users mailing list
Lensfun-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lensfun-users
