Rev 4887 contains the new code. **Warning**: I suffered the worst crash I have ever encountered while running unit tests for this yesterday: all open files, of whatever kind, got hosed. From a fleeting error message I suspect that the culprit was trying to dismiss the splash screen twice, and that caused a Python error that froze all open consoles!
The new code ensures that dismissing the splash screen can only be done from the main thread (that is, when not unit testing). It also never actually calls splashScreen.deleteLater, only splashScreen.hide, so it should be doubly safe. Now on to better news: 1. As expected, the dialogs are incredibly annoying. They are also very useful. Indeed, I discovered that some @auto unit tests files had @ignore in them. The workaround, should a user want to retain the @ignore but not get the dialogs is to change @file to @@file, or @auto to @@auto, etc. 2. I have chosen to emit dialogs whenever an import inserts @ignore, and also whenever *any* read or write encounters an @<file> node containing a top-level @ignore directive. Specifically, I have chosen *not* to remember that the read or write code has already given the dialog. Writing either the @<file> node, or the entire outline, will *always* give the dialog. Thus the annoyance. This simple code avoids some tricky AI that Leo would otherwise have to do in order to deduce whether the dialog "should" be given. I'm not going to change my mind about this: fundamental write code is the last place I need more complications. I'm also not inclined to add a user setting that would disable the dialogs: The workaround is simpler, safer and more flexible because it can be applied on an external-file-by-external-file basis. All comments welcome. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
