Hi Edward
    your explanation of the difference between #1240 and #1771 does, 
thanks. I think my issue is unrelated to any recent insights re. git 
branches etc.

I have tried the smallest example I could to illustrate what behaviour I 
see, and hope for. This is on:

Leo 6.4-devel, devel branch, build 30ca7ea314
2020-12-05 09:26:07 -0600
Python 3.6.9, PyQt version 5.9.5
linux

Steps:

1) In leo, create a new outline, say with a couple of nodes. save as 
myfile.leo.

2) keeping in leo, switch to a console, say. Edit the leo file  (or just 
'touch' it) in a text editor, save & exit

3) switch focus back to leo

4a) hoped for/expected: Leo notices the change and says "do you want me to 
reload the file into Leo?"

4b) observed: leo does not notice the change (yet)

4c) observed: if I then (or, later, after some leo editing activity) try to 
save the file in Leo, the fact that the underlying file has changed *is* 
noticed. I get a dialog box:

    dialog title: "Overwrite the version in Leo": dialog text: 
"<myfile.leo> has changed in leo\n Overwrite it?"

4d) observation: regardless, the text of this dialog is confusing.

I guess there are two non-usual situations here:

A) When acquiring focus (or through periodic checks), Leo notices that the 
file on disk has been changed somehow. It asks whether I want to reload the 
new file into Leo

B) before attempting to write the file, Leo notices that there is a 
discrepancy. It asks for confirmation whether I want to overwrite the file 
on disk

I would expect (A) to be the most usual/useful case; Leo currently seems to 
try for (B)

Does that help/make sense?

    thanks

    Jon N







On Monday, December 7, 2020 at 7:34:55 PM UTC Edward K. Ream wrote:

> On Mon, Dec 7, 2020 at 10:53 AM jkn <jkn...@nicorp.f9.co.uk> wrote:
>
> > I am not very clear about the differences between #1240 and #1771.
>
> #1240 <https://github.com/leo-editor/leo-editor/issues/1240> is an old 
> issue. It may have been inspired by your request, but I don't have any 
> memories. #1771 <https://github.com/leo-editor/leo-editor/pull/1771> is 
> simply the corresponding pull request.
>
> There are subtle, useful, differences between the descriptions (first 
> comments) of issues and pull requests. Pull requests are oriented towards 
> diffs. The corresponding issue is focused more on the big picture. But this 
> varies according to circumstance.
>
> Does this make sense?
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/6b132e3a-d9fc-41de-8fea-0b0000902034n%40googlegroups.com.

Reply via email to