I've never used g.findUnl() with patterns at all.  So as long as the newer 
one picks up legacy-style unls I'd be OK with it.

On Friday, July 7, 2023 at 7:36:26 PM UTC-4 Edward K. Ream wrote:

> g.findUnl is the handler for path-based unls. It contains two regex 
> patterns:
>
> # (file_name):(comma-separated list of node indices) 
> old_pat = re.compile(r'^(.*):(\d+),?(\d+)?,?([-\d]+)?,?(\d+)?$')
>
> # (file_name)::(line_number).
> new_pat = re.compile(r'^(.*?)(::)([-\d]+)?$')
>
> Leo's present unit tests cover only the new pattern.
>
> Notice the inconsistencies in the old regex. Does anyone still use it?
>
> Removing the old regex would eliminate other strange code. leoJS would 
> benefit.
>
> g.findUnl will remain unchanged for Leo 6.7.4.
>
> Your comments, please.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/7fb25a80-ff2d-43a8-99f5-35619d6ec89dn%40googlegroups.com.

Reply via email to